Re: [Xen-devel] [OSSTEST PATCH 3/1] ts-hosts-allocate-Executive: Print more info about booking to main log

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 3/1] ts-hosts-allocate-Executive: 
Print more info about booking to main log"):
> On Tue, 2015-09-29 at 16:27 +0100, Ian Jackson wrote:
> > Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > +               push @{ $prstart{ $book->{Start }} }, $pr;
> 
>                                                    ^ stray space?

Space in wrong place.  Should have read:

                    push @{ $prstart{ $book->{Start} } }, $pr;

(That's cosmetic only.)

> > +           my $pr = '';
> > +           foreach my $start (sort { $a <=> $b } keys %prstart) {
> > +               $pr .= " \@$start @{ $prstart{$start} }";
> 
> Even with one reso and its Xinfo this is going to be quite a long line,
> isn't it?
> 
> I don't think it really matters in the context, so in any case

Output looks like this:

2015-09-29 14:59:53 Z host allocation: planned start in 829 seconds.
2015-09-29 14:59:53 Z resource allocation: booking @829 host scape-moth [host].
2015-09-29 14:59:54 Z resource allocation: we are in the plan.

I see that in this case it _just_ fits into 80 columns :-).  But the
host allocation log is generally quite wide.  I think if this one line
wraps it's probably worthwhile.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel