Re: [Xen-devel] [PATCH] xen/arm: Correctly read the GICv3 Re-Distributor stride

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 30/09/15 12:04, Ian Campbell wrote:
> On Wed, 2015-09-30 at 11:54 +0100, Shameerali Kolothum Thodi wrote:
>> The GICv3 driver read a 32 bit value for the re-distributor stride, but
>> the dts binding is a two-cell property.
> 
> The binding doc I have says:
> 
> - redistributor-stride : If using padding pages, specifies the stride
>   of consecutive redistributors. Must be a multiple of 64kB.
> 
> i.e. it doesn't say anything about the size. The _example_ is 2 cells, but
> I don't think that is normative.
> 
> Unless you can point to a bindings update which specifies strictly two
> cells then I think the right answer is the use dt_read_number.

FWIW Linux is using of_property_read_u64 to get the stride. It has
always been the case and I don't understand how we end up to use
dt_property_u32 in Xen as we port the driver from Linux...

So before using dt_read_number in Xen, I would rather check if the DT
binding is not clear enough or the Linux drivers doesn't respect the
binding.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel