[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v6 24/29] xen/x86: allow HVM guests to use hypercalls to bring up vCPUs
El 30/09/15 a les 14.35, Jan Beulich ha escrit:
> On 30.09.15 at 14:19, <roger.pau@xxxxxxxxxx> wrote:
>> For VCPU_HVM_MODE_32B:
>> - rIP within CS limit.
>> - Check that CS.DPL == SS.DPL.
>> - rSP within SS limit.
>>
>> TBH I don't think we should enforce the last two checks, starting with
>> an invalid stack should be fine as long as the user knows it. Maybe
>> print a warning/debug message in this case?
>
> I wouldn't check ESP at all. As to the two DPLs to, I don't think you
> could launch a guest with these disagreeing.
I think we should basically check that the DPL of the CS segment is
equal or greater than the DPL of all the other segments (ds, ss and es).
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|