Re: [Xen-devel] [OSSTEST PATCH] Executive HTML output: Use #888888 (grey) for queued jobs

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-09-30 at 16:11 +0100, Ian Jackson wrote:
> Ian Jackson writes ("[OSSTEST PATCH] Executive HTML output: Use #888888
> (grey) for queued jobs"):
> > Either the flight hasn't started yet, or the job is blocked waiting
> > for other jobs to finish.  In any case their state is not very
> > interesting.
> > 
> > Most usefully this change visually distinguishes, in the plan summary,
> > jobs which are waiting for prior jobs to finish, from ones which have
> > entered the planning queue.
> 
> I didn't test this.  Ideally it would be tested by applying to the
> thing which is currently generating /~ianc/summary.html on the
> production VM.

I've just thrown it in there.

> > +    } elsif ($status eq '(queued)') {
> > +        return $single->("($status)", $grey),
> 
> The '(queued)' is wrong.
> 
> Ian.
> 
> From f0d8434ae0414b97898e67be5681c6d7e5318e14 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Date: Wed, 30 Sep 2015 16:02:49 +0100
> Subject: [OSSTEST PATCH] Executive HTML output: Use #888888 (grey) for
> queued
>  jobs
> 
> Either the flight hasn't started yet, or the job is blocked waiting
> for other jobs to finish.  In any case their state is not very
> interesting.
> 
> Most usefully this change visually distinguishes, in the plan summary,
> jobs which are waiting for prior jobs to finish, from ones which have
> entered the planning queue.
> 
> Also replace a $f->{status} with $status, which is less confusing.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
> v2: Get test right.
>     Update commit message.
> ---
>  Osstest/Executive.pm |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
> index aeb8c25..4cc34c7 100644
> --- a/Osstest/Executive.pm
> +++ b/Osstest/Executive.pm
> @@ -221,6 +221,7 @@ our $red=    '#ff8888';
>  our $yellow= '#ffff00';
>  our $purple= '#ff00ff';
>  our $blue=   '#0000ff';
> +our $grey=   '#888888';
>  
>  sub report_run_getinfo ($) {
>      # $f is a joined flight/job row, must contain at least
> @@ -272,8 +273,10 @@ END
>       };
>      } elsif ($status eq 'blocked') {
>          return $single->("blocked", $purple),
> +    } elsif ($status eq 'queued') {
> +        return $single->("($status)", $grey),
>      } else {
> -        return $single->("($f->{status})", $yellow);
> +        return $single->("($status)", $yellow);
>      }
>  }
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel