[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: Bump __XEN_LATEST_INTERFACE_VERSION__ to 0x00040700


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
  • Date: Wed, 30 Sep 2015 18:46:20 +0300
  • Cc: keir@xxxxxxx, tim@xxxxxxx, ian.jackson@xxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Wed, 30 Sep 2015 15:46:20 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=wY4CwTPjBsdJN7N8VeWOhFqU20Llk4XrCKYUFNJsFJbclfp7Gi3y5VBckdRLER63z5DdVTi5FcEz/ej8C11mdR3C5Z1b0VdXKFyJnXbg0b8dlicoqa9dCobe3xjtbH0CDxnyvJRjMlntXeQsGEie/D/8q6DsVhyjf4pAbDf5g/O4DBR3oT5KflNCBkkvGPgHHqixSrbNM2tEPFJIO14U2SKcybK3YR6lRhBLR1I4o9D1Nvh9LO259S5RzWpqEb9oHelf+5c3o9fvbDHda7XqQ836j9E19gJrBDLLLmBVAf25Wz+8SMs/f4oAmvbLgbRdQ11m+PO44To9d+Xp+edntQ==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 09/30/2015 06:39 PM, Jan Beulich wrote:
>>>> On 30.09.15 at 17:27, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>> On 09/30/2015 06:23 PM, Jan Beulich wrote:
>>>>>> On 30.09.15 at 17:16, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>>> VM_EVENT_FLAG_SET_REGISTERS and xc_monitor_emulate_each_rep() are
>>>> not available in Xen 4.6, hence the bump.
>>>
>>> I don't follow: These are additions, not changes that require
>>> consumers to adapt their code.
>>
>> I have code that checks for __XEN_LATEST_INTERFACE_VERSION__ and if it
>> is 0x00040700 then it uses xc_monitor_emulate_each_rep(), otherwise it
>> knows it can't - I thought that consumers that want to make use of the
>> latest API should be able to tell that they're allowed to do so.
>>
>> But if the Xen convention is to only bump it when the interface is no
>> longer backward compatible then I've misunderstood (in which case, sorry
>> for the noise, and also, is there another way to tell which Xen version
>> I'm compiling against?).
> 
> Just check for the relevant #define to be there.

That does work for VM_EVENT_FLAG_SET_REGISTERS in this case, but it
wouldn't have worked if the only addition would have been
xc_monitor_emulate_each_rep(). I like the XEN_VERSION and XEN_SUBVERSION
#defines in compile.h, but those don't make it into the public headers
(that end up in dist/install/usr/include after make dist).

But yes, in this case that #define is helpful, and then with autotools
or something similar libxc can be checked for xc_monitor_emulate_each_rep().

Again, sorry for the noise and thanks for the help.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.