[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/7] xen/arm: Warn when a device tree path will be re-used by Xen



On 01/10/15 13:01, Ian Campbell wrote:
> On Tue, 2015-09-29 at 17:21 +0100, Julien Grall wrote:
>> Xen is unconditionally using certain device tree paths to create DOM0
>> specific node (for instance /psci, /memory and /hypervisor).
>>
>> Print a warning message on the console to let the user know if we
>> re-use one of these nodes.
>>
>> Note that the content of most of those is very common and they
>> should have already been skipped via the compatible string or typer
> 
> Stray "r" at the end (fixable on commit)
> 
>> string. This warning is here to catch unusual device-tree and
>> compatible string that we may not yet support in Xen.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Should we consider using /xen-psci or something to avoid this conflict? Or
> (worse IMHO) adding a -N until we find an unused path?

If the /psci node is not removed because it uses a compatible string
which we don't support (i.e arm,psci-1.0 or else), we would end up
having 2 PSCI nodes in the DT. This would be harder to catch the problem
in the DT.

So I think we should stay with the current name.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.