Re: [Xen-devel] [PATCH v2 5/7] xen/arm: gic: Check the size of the CPU and vCPU interface retrieved from DT

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-10-01 at 13:43 +0100, Julien Grall wrote:
> On 01/10/15 13:08, Ian Campbell wrote:
> > On Tue, 2015-09-29 at 17:21 +0100, Julien Grall wrote:
> > > @@ -641,7 +643,30 @@ static int __init gicv2_init(void)
> > >          panic("GICv2: Cannot find the maintenance IRQ");
> > >      gicv2_info.maintenance_irq = res;
> > >  
> > > -    /* TODO: Add check on distributor, cpu size */
> > > +    /* TODO: Add check on distributor */
> > > +
> > > +    /*
> > > +     * The GICv2 CPU interface should at least be 8KB. Although,
> > > most of the DT
> > > +     * doesn't correctly set it and use the GICv1 CPU interface size
> > > (i.e 4KB).
> > > +     * Warn and then fixup.
> > > +     */
> > > +    if ( csize < SZ_8K )
> > > +    {
> > > +        printk(XENLOG_WARNING "GICv2: WARNING: "
> > > +               "The CPU interface size is wrong: %#"PRIx64
> > > +               " expected %#x\n",
> > 
> > You missed fixing a split string constant here.
> 
> Hmmm right. Although, I think the sentence is small so I don't need to
> rewrite it.

Correct. (If it weren't for the other comments I'd probably have just
unwrapped it when I committed)

> There is a lot small things to fix in this patch series. Shall I resend
> it?

Yes, please. I'm in the process of applying #1..#4 so you might want to
wait until they show up in staging and then rebase.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel