Re: [Xen-devel] [PATCH 4/5] libxc: split p2m allocation in domain builder from other magic pages

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-10-02 at 11:14 +0200, Juergen Gross wrote:
> On 10/02/2015 11:04 AM, Ian Campbell wrote:
> > On Fri, 2015-10-02 at 05:55 +0200, Juergen Gross wrote:
> > > On 10/01/2015 02:47 PM, Ian Campbell wrote:
> > > > On Fri, 2015-09-11 at 14:32 +0200, Juergen Gross wrote:
> > > > > Add an own function to allocate the p2m list in the domain
> > > > > builder in
> > > > 
> > > > I'm not sure what you mean by "own" here. Perhaps "hook" or
> > > > "callback"?
> > > 
> > > Before the p2m list allocation was done in the alloc_magic_pages
> > > hook.
> > > I'm just splitting this function.
> > 
> > I get that, but "own" is not the right word for this.
> 
> Obviously.

It occurred to me afterwards that "into its own function" would be one way
to express this, so I see know how you got to that wording.

> > Perhaps you meant "separate (hook|function)" or "specific
> > (hook|function)"
> > or something like that?
> > 
> > Perhaps something like:
> > 
> >      Refactor allocation of the p2m list out of alloc_magic_pages into
> > a new
> >      alloc_p2m_list hook.
> 
> In v2 I've changed the wording in a similar way.

I'll go have a look.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel