Re: [Xen-devel] [PATCH v7 13/32] xen/vlapic: fixes for HVM code when running without a vlapic

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 02/10/15 16:48, Roger Pau Monne wrote:
> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
> index bbec0e8..63b7a24 100644
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -2412,7 +2412,8 @@ static void vmx_install_vlapic_mapping(struct vcpu *v)
>  {
>      paddr_t virt_page_ma, apic_page_ma;
>  
> -    if ( !cpu_has_vmx_virtualize_apic_accesses )
> +    if ( !cpu_has_vmx_virtualize_apic_accesses ||
> +         v->domain->arch.hvm_domain.vmx.apic_access_mfn == 0 )

0 is a valid (albeit very unlikely) mfn.  The unused sentinel value
should be INVALID_MFN.  It appears that all the current uses of
apic_access_mfn are buggy.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel