Re: [Xen-devel] [PATCH v7 13/32] xen/vlapic: fixes for HVM code when running without a vlapic

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 10/02/2015 11:48 AM, Roger Pau Monne wrote:
> The HVM related code (SVM, VMX) generally assumed that a local apic is
> always present. With the introduction of a HVM mode were the local apic can
> be removed, some of this broken code paths arised.
>
> The SVM exit/resume paths unconditionally checked the state of the lapic,
> which is wrong if it's been disabled by hardware, fix this by adding the
> necessary checks. On the VMX side, make sure we don't add mappings for a
> local apic if it's disabled.
>
> In the generic vlapic code, add checks to prevent setting the TSC deadline
> timer if the lapic is disabled, and also prevent trying to inject interrupts
> from the PIC is the lapic is also disabled.
>
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Cc: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>
> Cc: Eddie Dong <eddie.dong@xxxxxxxxx>
> Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> ---
>   xen/arch/x86/hvm/svm/svm.c | 18 ++++++++++--------
>   xen/arch/x86/hvm/vlapic.c  |  7 ++++++-
>   xen/arch/x86/hvm/vmx/vmx.c |  3 ++-
>   3 files changed, 18 insertions(+), 10 deletions(-)

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel