Re: [Xen-devel] [PATCH OSSTEST 6/8] ts-kernel-build: Include dtbs in dist file

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-10-05 at 17:22 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST 6/8] ts-kernel-build: Include dtbs
> in dist file"):
> > These are installed to $(INSTALL_PATH)/dtbs/$(KERNEL_RELEASE) where
> > $(INSTALL_PATH) defaults to /boot but we override it to our staging
> > /boot.
> 
> Thanks for the detailed explanation.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> > -   make $makeflags INSTALL_MOD_PATH=$builddir/dist
> > modules_install
> > +   make $makeflags \\
> > +           INSTALL_PATH=$builddir/dist/boot \\
> > +           INSTALL_MOD_PATH=$builddir/dist modules_install \\
> > +           $dtbs_install
> 
> I tripped over the formatting here.  It would be nicer to put
> `modules_install' on the next line, to avoid hiding it in
> INSTALL_BLAH=.

I did it that way because INSTALL_MOD_PATH is the variable which controls
where modules_install puts things, so they are in some sense related.

Next line is fine too, or I could move it to first on the line it is on
now?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel