Re: [Xen-devel] [OSSTEST PATCH 2/2] make-flight: create the vNUMA HVM test job

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-10-05 at 17:41 +0100, Wei Liu wrote:
> On Mon, Oct 05, 2015 at 05:34:11PM +0100, Ian Jackson wrote:
> > Dario Faggioli writes ("[OSSTEST PATCH 2/2] make-flight: create the
> > vNUMA HVM test job"):
> > > as a variant of regular Debian HVM jobs.
> > > 
> > > For now, the vNUMA topology is just hardcoded
> > > here, and it is 4 vCPUs and 2 vNUMA nodes. How
> > > to split resources is left to the test
> > > implementation (right now, it is just evenly
> > > split them between the 2 virtual nodes).
> > 
> > The make-flight changes here seem reasonable.
> > 
> > > Note that we do not yet support save/restore
> > > and migration for vNUMA enabled guests, so
> > > this test will fail (and in fact, it's added
> > > to the non-blocking list).
> > 
> > However, this is wrong.  Instead, you should arrange for
> > ts-migrate-support-check to fail in this case.
> > 
> 
> My two cents.
> 
> We don't need to make ts-migrate-support-check fail. It is fine for the
> actual migration test to fail at the beginning as it won't block the
> push gate. It's conceivable that vNUMA guest will be able to migrate in
> the future. When that comes true, the actual migration test will pass.

I think the point was that if the migration tests fails then all subsequent
test steps won't get run at all (apart from leak check & log collection
etc).

Whereas if ts-migrate-support-check fails then the migrations will be
skipped and those other tests will be run.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel