Re: [Xen-devel] [PATCH v2 2/9] xen/arm: io: Extend write/read handler to pass the register in parameter

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2015-10-05 at 13:58 +0100, Julien Grall wrote:
> On 05/10/15 13:51, Julien Grall wrote:
> > Rather than letting each handler to retrieve the register used by the
> > I/O access, add a new parameter to pass the register in parameter.
> > 
> > This will help to implement generic register manipulation on I/O access
> > such as sign-extension and endianess.
> > 
> > Read handlers need to modify the value of the register, so a pointer to
> > it is given in argument. Write handlers shouldn't modify the register,
> > therefore only a plain value is given.
> > 
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > ---
> > 
> > Ian, I haven't kept my Acked-by because of code clash while rebasing
> > on top of "xen/arm: io: Extend write/read handler to pass private data"
> > [1].
> 
> Hmmm, this doesn't match what I did (i.e keeping the acked-by from Ian).
> 
> The conflict with "xen/arm: io: Extend write/read handler to pass
> private data" should not be controversial. Let me know if you disagree.

It's fine.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel