Re: [Xen-devel] [PATCH OSSTEST 4/5] standalone: Make it possible to pass options to run-test

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-10-06 at 15:59 +0100, Ian Campbell wrote:
> On Tue, 2015-10-06 at 15:46 +0100, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST 4/5] standalone: Make it possible
> > to
> > pass options to run-test"):
> > > Currently the remainder of the comnand line is passed after the host=
> > > ident, which allows for other idents to be given, which isn't all
> > > that
> > > useful in practice.
> > > 
> > > Instead arrange that any additional options up to a "--" marker are
> > > passed before host= and anything after are passed after.
> > ...
> > > -     with_logging logs/$flight/$job.$ts.log ./$ts $hosts $@
> > > +     with_logging logs/$flight/$job.$ts.log ./$ts
> > > ${options[@]}
> > > $hosts $@
> > 
> > You mean   ... ./$ts "${options[@]}" $hosts ...
> > by analogy with  "$@"
> 
> We (well, I, since I wrote that) don't use "$@" above but just the bare
> $@,
> which I copied. I suppose that one is wrong too?

I've decided it is and will insert a patch to fixup various unquoted uses
of $@.

Also in this patch was
+       for i in $@ ; do
which is similarly wrong, I think.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel