Re: [Xen-devel] [PATCH v5 3/9] x86/intel_pstate: add a new driver interface, setpolicy()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.09.15 at 04:32, <wei.w.wang@xxxxxxxxx> wrote:
> In order to better support future Intel processors, intel_pstate
> changes to use percentage values to tune P-states. The setpolicy
> driver interface is used to configure the intel_pstate internal
> policy. The __cpufreq_set_policy needs to be intercepted to use
> the setpolicy driver if it exists.
> 
> Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx>

Andrew having given his R-b I'm going to apply this as is, but I don't
see how ...

> --- a/xen/drivers/cpufreq/utility.c
> +++ b/xen/drivers/cpufreq/utility.c
> @@ -456,6 +456,9 @@ int __cpufreq_set_policy(struct cpufreq_policy *data,
>  
>      data->min = policy->min;
>      data->max = policy->max;
> +    data->limits = policy->limits;

... this and ...

> --- a/xen/include/acpi/cpufreq/cpufreq.h
> +++ b/xen/include/acpi/cpufreq/cpufreq.h
> @@ -41,6 +41,18 @@ struct cpufreq_cpuinfo {
>      unsigned int        transition_latency; /* in 10^(-9) s = nanoseconds */
>  };
>  
> +struct perf_limits {
> +    bool_t no_turbo;
> +    bool_t turbo_disabled;
> +    uint32_t turbo_pct;
> +    uint32_t max_perf_pct; /* max performance in percentage */
> +    uint32_t min_perf_pct; /* min performance in percentage */
> +    uint32_t max_perf;
> +    uint32_t min_perf;
> +    uint32_t max_policy_pct;
> +    uint32_t min_policy_pct;
> +};

.. this are related to the patch subject. In particular it is impossible
to tell at this point whether and how all of the fields above are
going to be used. Please try to split patch series into _logical_
pieces.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel