Re: [Xen-devel] [PATCH XEN v3 02/22] tools: Refactor "xentoollog" into its own library

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-10-07 at 15:42 +0100, Andrew Cooper wrote:

> > +.PHONY: install
> > +install: build
> > +   $(INSTALL_DIR) $(DESTDIR)$(libdir)
> > +   $(INSTALL_DIR) $(DESTDIR)$(includedir)
> > +   $(INSTALL_SHLIB) libxentoollog.so.$(MAJOR).$(MINOR)
> > $(DESTDIR)$(libdir)
> > +   $(INSTALL_DATA) libxentoollog.a $(DESTDIR)$(libdir)
> > +   $(SYMLINK_SHLIB) libxentoollog.so.$(MAJOR).$(MINOR)
> > $(DESTDIR)$(libdir)/libxentoollog.so.$(MAJOR)
> > +   $(SYMLINK_SHLIB) libxentoollog.so.$(MAJOR)
> > $(DESTDIR)$(libdir)/libxentoollog.so
> 
> Installation of all .so's needs to be conditional on $(nosharedlibs) to
> match the condition in the build rule.

This isn't true of any of the existing in tree things (e.g. the existing
libxenctrl Makefile, the xenstore one etc).

I think because the nosharedlibs mode is specifically for stubdom (and
rumpkernel?) and we do not (yet?) support install for builds of those
types.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel