Re: [Xen-devel] [PATCH v5 6/9] x86/intel_pstate: the main boby of the intel_pstate driver

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.09.15 at 04:32, <wei.w.wang@xxxxxxxxx> wrote:
> We simply grab the fundamental logic of the intel_pstate driver
> from Linux kernel, and customize it to Xen style. In the kernel,
> a user can adjust the limits via sysfs
> (limits.min_sysfs_pct/max_sysfs_pct). In Xen, the
> policy->limits.min_perf_pct/max_perf_pct acts as the transit
> station. A user interacts with it via xenpm.
> 
> The new xen/include/asm-x86/cpufreq.h header file is added.
> 
> Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx>

I went back to the replies I sent on earlier versions (namely v2), and
finding several issues un-addressed or only partly addressed I'm not
going to re-review this patch in detail, NAK-ing it in its current shape.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel