Re: [Xen-devel] [PATCH v6 3/3] tools & docs: add tools and docs support for Intel CDP

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

He Chen writes ("[PATCH v6 3/3] tools & docs: add tools and docs support for 
Intel CDP"):
> This is the xl/xc changes to support Intel Code/Data Prioritization.
> CAT xl commands to set/get CBMs are extended to support CDP.
> Add new CDP options with CAT commands in xl interface man page.
> Add description of CDP in xl-psr.markdown.
> 
> Signed-off-by: He Chen <he.chen@xxxxxxxxxxxxxxx>

I have reviewed this with my tools hat on.  I am not an expert in this
area.  It's possible that the docs could be improved but overall I'm
content.

I have one very minor nit.  Several lines in the docs are too long,
for example:

> +The xl interfaces are the same with that of CAT. The difference is that \
CBM type
> +can be passed as option to set code CBM or data CBM.

This leads to wrap damage when reviewing patches and editing docs.
Can you rewrap them, preferably to 75 or fewer ?


I'm expecting the semantics and hypercall interfaces etc. to be
reviewed by hypervisor maintainers.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel