[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH OSSTEST v4 4/7] standalone: Correctly quote $@ where it is used.



Else arguments with spaces become multiple arguments.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 standalone | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/standalone b/standalone
index 7c7fde9..25e23ca 100755
--- a/standalone
+++ b/standalone
@@ -197,7 +197,7 @@ with_logging() {
     local log=$1; shift
     ensure_logs
     savelog -c 300 "$log" >/dev/null
-    $@ 2>&1 | tee "$log"
+    "$@" 2>&1 | tee "$log"
     rc=${PIPESTATUS[0]}
     if [ $rc -ne 0 ] ; then
        echo "FAILED rc=${rc}" >&2
@@ -240,7 +240,7 @@ case $op in
         OSSTEST_FLIGHT=$flight \
         OSSTEST_CONFIG=$config \
         OSSTEST_NO_BASELINE=$nobaseline \
-            with_logging logs/$flight/make-flight.log ./cr-daily-branch $@ 
$branch
+            with_logging logs/$flight/make-flight.log ./cr-daily-branch "$@" 
$branch
         ;;
 
     set-paths)
@@ -321,7 +321,7 @@ case $op in
        OSSTEST_FLIGHT=$flight \
        OSSTEST_HOST_REUSE=$reuse \
        OSSTEST_JOB=$job \
-           with_logging logs/$flight/$job.$ts.log ./$ts $hosts $@
+           with_logging logs/$flight/$job.$ts.log ./$ts $hosts "$@"
        ;;
 
     get-job-status)
-- 
2.5.3


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.