Re: [Xen-devel] [PATCH v3 7/9] xen/arm: vgic: Optimize the way to store the target vCPU in the rank

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 08/10/15 15:25, Ian Campbell wrote:
>> If the concern is the behavior is changed, I'm happy to rework this code
>> to keep exactly the same behavior. I.e any 32-bit write containing
>> a 0 byte will be ignored. This is not optimal but at least I'm not
>> opening the pandora box of fixing every single error in the code touch
>> by this series.
> 
> I'm okay with the new behaviour, I think Stefano was willing to tolerate it
> (based on <alpine.DEB.2.02.1510081220190.1179@xxxxxxxxxxxxxxxxxxxxxxx>).

It's what I understand too. I will a resend a new version tomorrow.

> So if we aren't going to fix it to DTRT WRT writing zero to a target then I
> think we can go with the current variant and not change to ignoring any
> word with a zero byte in it.

I'm thinking to split this patch in two:
        - One which will turn the current ITARGETSR emulation in a function
with the change of behavior when writing zero to a target.
        - The other to optimize the way we store the target.

This will keep the second patch nearly mechanical and avoid to change
multiple behavior within the same patch.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel