Re: [Xen-devel] [PATCH] xen/arm: ctxt_switch: Document the erratum #852523 related to Cortex A57

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 09/10/15 10:22, Ian Campbell wrote:
> On Thu, 2015-10-08 at 20:22 +0100, Julien Grall wrote:
>> When restoring the system register state for an AArch32 guest at EL2,
>> writes to DACR32_EL2 may not be correctly synchronised by Cortex-A57,
>> which can lead to the guest effectively running into unexpected domain
>> faults.
>>
>> Thankfully, we don't hit this erratum in Xen. Nonetheless, document the
>> code to prevent any introduction of the erratum if the context switch
>> code is re-ordered.
>>
>> Link: http://lists.xen.org/archives/html/xen-devel/2015-09/msg01746.html
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> nits:
>>  
>> +    /*
>> +     * This write to sysreg CONTEXTIDR_EL1 ensure we don't hit the erratum
> 
> "ensures" and s/the //.
> 
> (fixable on commit)

I'm fine if you fix it while committing.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel