Re: [Xen-devel] Regression: debug not setted correctly in config/Tools.mk of xen 4.6

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 09, 2015 at 05:13:20PM +0200, Fabio Fantoni wrote:
> In latest weeks building xen 4.6 with debug enable qemu trace was missed,
> today building xen 4.6.0 I found the cause.
> Even if debug ?= y in Config.mk, config/Tools.mk is not generate correctly,
> have this line:
> debug               := @debug@
> 
> I not found the exact cause for doing the patch that fix it, can someone
> help me please?
> 

commit 16181cbb107ea70a72f41982b371c444926f48f2
Author: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Date:   Wed Sep 2 10:34:55 2015 +0100

    tools: Honor Config.mk debug value, rather than setting our own
    
    Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add
    macro debugging information') exposed a bug whereby the autoconf stuff
    in tools was setting its own debug value (defaulting to ENABLED, even
    for releases) instead of honoring the value set in Config.mk.
    
    After that changeset, if the global build has -D_FORTIFY_SOURCE
    enabled (as is the default in CentOS 7 rpmbuild), then the tools build
    will fail (because debug builds default to on).
    
    There should be only one place to specify whether to build debug or
    not, and Config.mk is already included by the relevant makefiles.  So
    simply remove the tools/configure debug option and everything falls
    into place naturally.
    
    Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
    Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>


With that change the debug value in Tools.mk.in is not useful anymore --
at least that was the intent.

However the unforeseen consequence is that tools/Makefile includes
config/Tools.mk, so the statement "debug := @debug@" shadows the one set
in Config.mk. That means we can't ever get a debug build of tools
anymore.

I will post a patch to fix that.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel