Re: [Xen-devel] [PATCH] build: don't shadow debug with "@debug@" in tools build

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 11/10/15 15:41, Wei Liu wrote:
> In 16181cbb (tools: Honor Config.mk debug value, rather than setting our
> own), configure doesn't set debug variable anymore. There is, however,
> one place that was missed. The file config/Tools.mk.in was still
> expecting a @debug@ value from configure. After 16181cbb that value
> remained "debug := @debug@" all the time because configure didn't
> substitute it.
> 
> The consequence was that we couldn't get a debug build even if debug was
> set to "y" in Config.mk.
> 
> Fix this by removing the stray line "debug := @debug@" in Tools.mk.in.
> 
> Reported-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Oops -- tested not turning it on, but didn't test turning it on. :-)

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>

> ---
> Cc: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> 
> Backport candidate for 4.6.
> ---
>  config/Tools.mk.in | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> index 9bd5f6c..ccfe137 100644
> --- a/config/Tools.mk.in
> +++ b/config/Tools.mk.in
> @@ -5,9 +5,6 @@ ifeq ($(CONFIG_RUMP),y)
>  XEN_OS              := NetBSDRump
>  endif
>  
> -# A debug build of tools?
> -debug               := @debug@
> -
>  # Tools path
>  BISON               := @BISON@
>  FLEX                := @FLEX@
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel