Re: [Xen-devel] [OSSTEST PATCH 19/26] Toolstack::xl: Provide block_attach method

["Hu, Robert" <robert.hu@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@xxxxxxxxxxxxx]
> Sent: Saturday, September 26, 2015 3:15 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Hu, Robert <robert.hu@xxxxxxxxx>; Ian Campbell
> <ian.campbell@xxxxxxxxxx>; Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Ian
> Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Subject: [OSSTEST PATCH 19/26] Toolstack::xl: Provide block_attach method
> 
> It is possible that this may work some of the time with xm, so I have
> taken no measures to prevent it running then.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ----
> v14: New patch
> ---
>  Osstest/Toolstack/xl.pm |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Osstest/Toolstack/xl.pm b/Osstest/Toolstack/xl.pm
> index 0f8abed..cc26d61 100644
> --- a/Osstest/Toolstack/xl.pm
> +++ b/Osstest/Toolstack/xl.pm
> @@ -109,4 +109,12 @@ sub restore ($$$$) {
>                   ." $f", $timeout);
>  }
> 
> +sub block_attach ($$$$) {
> +    my ($self,$gho,$xldiskspec) = @_;
> +    die "quotes in $xldiskspec ?" if $xldiskspec =~ m/'/;
> +    my $gn = $gho->{Name};
> +    my $cmd = $self->{_VerboseCommand}." block-attach $gn
> '$xldiskspec'";

I guess here lacks of a
        my $ho = $self->{Host};

> +    target_cmd_root($ho, $cmd, 100);
> +}
> +
>  1;
> --
> 1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel