Re: [Xen-devel] [PATCH] x86/Centaur: drop __init annotations

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/10/15 14:27, Jan Beulich wrote:
>>>> On 14.10.15 at 15:22, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 14/10/15 14:06, Jan Beulich wrote:
>>> Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as
>>> __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing
>>> the pointers hanging off of it. Even if CPU hotplig support may be
>>> purely theoretical for Centaur, we should still not leave this as is.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Surely they should be __cpuinit to match __cpuinitdata.
>>
>> This will have the same effect, as __cpuinit is empty on x86.
> Actually all the __{cpu,dev}init{,data} should go away, which is
> why I wouldn't want to needlessly add them here.

I suppose they should.  I will draft a patch.

In the mean time, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel