Re: [Xen-devel] [PATCH QEMU-XEN v3 2/8] xen: Switch to libxengnttab interface for compat shims.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-10-14 at 14:30 +0100, Stefano Stabellini wrote:
> @@ -71,11 +71,29 @@ static inline int xenevtchn_close(xenevtchn_handle
> > *h)
> >  #define xenevtchn_unmask(h,p) xc_evtchn_unmask(*h,p)
> >  #define xenevtchn_unbind(h,p) xc_evtchn_unmask(*h,p)
> >  
> > -static inline XenGnttab xen_xc_gnttab_open(void *logger,
> > -                                           unsigned int open_flags)
> > +static inline xengnttab_handle *xengnttab_open(void *logger,
> > +                                          unsigned int
> > open_flags)
> >  {
> > -    return xc_gnttab_open();
> > +    int *h = malloc(sizeof h);
>                        ^
>                        sizeof (*h)

FYI I've done this mistake in all the patches, and will fix all in one go,
so you can skip this for the remainder.

> > +    if (!h)
> > +   return NULL;
> 
> indentation

Probably this too, but I will check them all so no need to keep checking.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel