Re: [Xen-devel] [PATCH v7 16/32] xen/x86: allow disabling the pmtimer

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.10.15 at 17:48, <roger.pau@xxxxxxxxxx> wrote:
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Changes since v6:
>  - Return ENODEV in pmtimer_load if the timer is disabled.
>  - hvm_acpi_power_button and hvm_acpi_sleep_button become noops if the
>    pmtimer is disabled.

But how are those two features connected? I don't think you can
assume absence of a PM block just because there's no PM timer.
Or if you want to tie them together for now, the predicate needs
to be renamed.

>  - Return ENODEV if pmtimer_change_ioport is called with the pmtimer
>    disabled.

Same here.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel