Re: [Xen-devel] [PATCH RFC 2/3] xen/hvm: introduce a fpu_initialised filed to the CPU save record

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.10.15 at 18:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 14/10/15 17:24, Roger Pau Monne wrote:
>> @@ -157,9 +158,121 @@ struct hvm_hw_cpu {
>>      };
>>      /* error code for pending event */
>>      uint32_t error_code;
>> +    /* is fpu initialised? */
>> +    uint8_t fpu_initialised:1;
> 
> Bitfields can't be used in the public ABI, and please don't leave
> trailing implicit padding.
> 
> I would recommend uint32_t flags and specify that bit 0 indicates that
> fpu context is initialised.

Seconded, despite the bad precedent in the pending event sub-union.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel