Re: [Xen-devel] [PATCH] libxc: fix the types used in xc_dom_image to build HVM guests

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/10/15 18:16, Ian Campbell wrote:
> On Thu, 2015-10-15 at 18:52 +0200, Roger Pau Monné wrote:
>> El 15/10/15 a les 18.41, Ian Campbell ha escrit:
>>> On Thu, 2015-10-15 at 18:30 +0200, Roger Pau Monne wrote:
>>>> Fix the types used to store the memory parameters of an HVM guest,
>>>> previously they defaulted to unsigned long on 32bit toolstack
>> builds, which
>>>> is wrong because a 32bit value cannot hold a 64bit memory address
>> that
>>>> crosses the 4GB boundary.
>>> This header includes a xen_paddr_t in it which looks like the
>> appropriate
>>> type for most of these.
>>>
>>> The ones which have units of pages which you've changed from
>> xen_pfn_t to
>>> unsigned long (not long long) should surely remain xen_pfn_t? At
>> least
>>> target_pages should IMHO.
>>>
>>> lowmem_end doesn't strictly need to be 64-bit, but xen_paddr_t
>> seems like
>>> the appropriate type semantically nonetheless.
>> Right, I didn't realize we had a xen_paddr_t type, thanks to Juergen
>> and
>> you for pointing it out. mmio_size is not a paddr, so I'm going to
>> leave
>> it as unsigned long long.
> The size of a paddr region can be considered to be a paddr from my PoV.

+1.  Better to use xen_paddr_t across the board than to mix and match.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel