Re: [Xen-devel] [PATCH] xen-netback: corretly check failed allocation

[Insu Yun <wuninsu@xxxxxxxxx>]

Sorry for wrong format, I forgot to change my configuration.

On Thu, Oct 15, 2015 at 1:13 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:

On Thu, Oct 15, 2015 at 12:26:16PM -0400, Insu Yun wrote:
> Since vzalloc can be failed in memory pressure,
> return value should be checked and return ENOMEM.

This function doesn't return ENOMEM, instead it writes to xenstore to
indicate error. The commit log needs to be updated.

Good. I will update it.

Â

>
> Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx>
> ---
>Â drivers/net/xen-netback/xenbus.c | 5 +++++
>Â 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
> index 929a6e7..e288246 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -788,6 +788,11 @@ static void connect(struct backend_info *be)
>Â Â Â Â/* Use the number of queues requested by the frontend */
>Â Â Â Âbe->vif->queues = vzalloc(requested_num_queues *
>Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âsizeof(struct xenvif_queue));
> +Â if (!be->vif->queues)Â {
> +Â Â xenbus_dev_fatal(dev, -ENOMEM, "allocating queues");
> +Â Â return;
> +Â }
> +

The indentation is wrong. Please configure your email client properly.

And please use "goto err" for error handling -- yes, I understand there
is existing code that returns directly but IMHO that should be fixed
too.

Ok. Actually I made a code referring the existing code.

Â

We.

>Â Â Â Âbe->vif->num_queues = requested_num_queues;
>Â Â Â Âbe->vif->stalled_queues = requested_num_queues;
>
> --
> 1.9.1

--

Regards

Insu Yun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel