Re: [Xen-devel] [PATCH v2] libxc: fix the types used in xc_dom_image to build HVM guests

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 16, 2015 at 09:57:02AM +0100, Ian Campbell wrote:
> On Thu, 2015-10-15 at 19:23 +0200, Roger Pau Monne wrote:
> > Fix the types used to store the memory parameters of an HVM guest,
> > previously they defaulted to unsigned long on 32bit toolstack builds, which
> > is wrong because a 32bit value cannot hold a 64bit memory address that
> > crosses the 4GB boundary.
> 
> Just for my own interest, I suppose this was a latent issue even before the
> dom builder rework, but what was the change which exposed it now?
> 

I don't think this is a latent issue.

During the refactoring a bunch of types were changed to unsigned long.
The original types used were uint64_t, which is of the same width on 32
bit and 64 bit.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel