Re: [Xen-devel] [PATCH 2/5] raisin: Detect systemd

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 16 Oct 2015, Ian Campbell wrote:
> On Fri, 2015-10-16 at 14:39 +0100, Stefano Stabellini wrote:
> > On Wed, 14 Oct 2015, George Dunlap wrote:
> > > Add systemd development libraries if we detect systemd present on the
> > > system
> > > 
> > > Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> > 
> > Please use spaces for indentation
> > 
> >     
> > >  components/xen | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/components/xen b/components/xen
> > > index 090cceb..93ed288 100644
> > > --- a/components/xen
> > > +++ b/components/xen
> > > @@ -8,6 +8,11 @@ function xen_check_package() {
> > >      local DEP_Debian_common="build-essential python-dev gettext uuid
> > > -dev   \
> > >               libncurses5-dev libyajl-dev libaio-dev pkg-config
> > > libglib2.0-dev  \
> > >               libssl-dev libpixman-1-dev bridge-utils wget"
> > > +
> > > +    if [[ -e "/usr/lib/systemd" ]]
> > 
> > I don't know much about systemd but isn't there a better way to detect
> > systemd? Check if it is running for example?
> 
> You might want to build with systemd support even if systemd isn't actually
> the current init system the system was booted with?

That is possible but also the vice versa might be true: one might want
to build without systemd even if systemd is running. Maybe we need some
kind of variable that can be overridden by the user?


> > 
> > > +    then
> > > + DEP_Debian_common="$DEP_Debian_common libsystemd-daemon-dev"
> > > +    fi
> > >      local DEP_Debian_x86_32="$DEP_Debian_common bcc iasl bin86
> > > texinfo"
> > >      local DEP_Debian_x86_64="$DEP_Debian_x86_32 libc6-dev-i386"
> > >      local DEP_Debian_arm32="$DEP_Debian_common libfdt-dev"
> > > @@ -16,6 +21,10 @@ function xen_check_package() {
> > >      local DEP_Fedora_common="make gcc python-devel gettext libuuid
> > > -devel   \
> > >               ncurses-devel glib2-devel libaio-devel openssl-devel yajl
> > > -devel   \
> > >               patch pixman-devel glibc-devel bridge-utils grub2 wget
> > > tar bzip2"
> > > +    if [[ -e "/usr/lib/systemd" ]]
> > > +    then
> > > + DEP_Fedora_common="$DEP_Fedora_common systemd-devel|systemd
> > > -container-devel"
> > > +    fi
> > >      local DEP_Fedora_x86_32="$DEP_Fedora_common dev86 acpica-tools
> > > texinfo"
> > >      local DEP_Fedora_x86_64="$DEP_Fedora_x86_32 glibc-devel.i686"
> > >  
> > > @@ -23,6 +32,7 @@ function xen_check_package() {
> > >      local DEP_CentOS_x86_32="$DEP_CentOS_common dev86 texinfo iasl"
> > >      local DEP_CentOS_x86_64="$DEP_CentOS_x86_32 glibc-devel.i686"
> > >  
> > > +
> > 
> > spurious change
> > 
> > 
> > >      verbose_echo Checking Xen dependencies
> > >      eval check-package \$DEP_"$DISTRO"_"$RAISIN_ARCH"
> > >  }
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel