Re: [Xen-devel] [xen-unstable bisection] complete test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Oct 19, 2015 at 03:09:29AM -0600, Jan Beulich wrote:
> >>> On 19.10.15 at 11:02, <wei.liu2@xxxxxxxxxx> wrote:
> > On Sat, Oct 17, 2015 at 10:55:52PM +0000, osstest service owner wrote:
> >> branch xen-unstable
> >> xen branch xen-unstable
> >> job test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm
> >> test debian-hvm-install
> >> 
> >> Tree: linux git://xenbits.xen.org/linux-pvops.git
> >> Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git
> >> Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git
> >> Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git
> >> Tree: xen git://xenbits.xen.org/xen.git
> >> 
> >> *** Found and reproduced problem changeset ***
> >> 
> >>   Bug is in tree:  xen git://xenbits.xen.org/xen.git
> >>   Bug introduced:  c64ef24febcf5bc6c6da733abd256412da8c4895
> >>   Bug not present: 2fe4c0060c62a012109dab1d981522dc26822110
> >> 
> >> 
> >>   commit c64ef24febcf5bc6c6da733abd256412da8c4895
> >>   Author: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> >>   Date:   Fri Oct 2 17:48:33 2015 +0200
> >> 
> >>       libxc: split x86 HVM setup_guest into smaller logical functions
> >> 
> >>       This is just a preparatory change to clean up the code in 
> >> setup_guest.
> >>       Should not introduce any functional changes.
> >> 
> >>       Signed-off-by: Roger Pau Monn?? <roger.pau@xxxxxxxxxx>
> >>       Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >>       Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >>       Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >>       Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> >>       Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >>       Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> 
> >> 
> >> For bisection revision-tuple graph see:
> >>    
> > http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable/test
> >  
> > -amd64-i386-xl-qemuu-debianhvm-amd64-xsm.debian-hvm-install.html
> >> Revision IDs in each graph node refer, respectively, to the Trees above.
> >> 
> > 
> > The bug has been fixed in staging and we already got a push.
> 
> And that fix is commit c787425fdf ("libxc: fix the types used in
> xc_dom_image to build HVM guests")? I ask because the commit

Yes.

> message doesn't say anything like that, and it's not immediately
> clear why only an *-xsm test should have been affected by the
> issue.
>

It's not that XSM is particularly affected. It's just that particular
test case  happened to run on merlot{0,1} which have a lot of memory.

The HVM test case has a property when it knows the host has large enough
free memory, it will try to bump the guest memory beyond 4G -- I
deliberately made it work like that so that it can catch bug like this
one introduced by misuse of types.

Wei.

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel