Re: [Xen-devel] [PATCH v3] raisin: enable ovmf build for arm64

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 16 Oct 2015, Julien Grall wrote:
> On 16/10/15 12:42, Stefano Stabellini wrote:
> >  function ovmf_check_package() {
> > -    local DEP_Debian_common="build-essential nasm uuid-dev python iasl"
> > -    local DEP_Debian_x86_32="$DEP_Debian_common"
> > -    local DEP_Debian_x86_64="$DEP_Debian_common"
> > -    local DEP_Debian_arm32="$DEP_Debian_common"
> > +    local DEP_Debian_common="build-essential uuid-dev python iasl"
> > +    local DEP_Debian_x86_32="$DEP_Debian_common nasm"
> > +    local DEP_Debian_x86_64="$DEP_Debian_x86_32"
> >      local DEP_Debian_arm64="$DEP_Debian_common"
> >  
> > -    local DEP_Fedora_common="make gcc gcc-c++ nasm libuuid-devel python 
> > acpica-tools"
> > -    local DEP_Fedora_x86_32="$DEP_Fedora_common"
> > -    local DEP_Fedora_x86_64="$DEP_Fedora_common"
> > +    local DEP_Fedora_common="make gcc gcc-c++ libuuid-devel python 
> > acpica-tools"
> > +    local DEP_Fedora_x86_32="$DEP_Fedora_common nasm"
> > +    local DEP_Fedora_x86_64="$DEP_Fedora_x86_32"
> > +    local DEP_Fedora_arm64="$DEP_Debian_common"
> 
> Shouldn't it be $DEP_Fedora_common here?

Yes, it should!


> > +
> > +    local DEP_CentOS_common="$DEP_Fedora_common"
> > +    local DEP_CentOS_x86_32="$DEP_Fedora_x86_32"
> > +    local DEP_CentOS_x86_64="$DEP_Fedora_x86_64"
> > +    local DEP_CentOS_arm64="$DEP_Fedora_arm64"
> 
> It's bit strange to introduce DEP_CentOS_* in a patch which only enable
> ARM64. Is it intentional?

Yes, it is intentional: I tested it on CentOS. So far we have been
adding CentOS dependencies "on demand". I'll mention it in the commit
message.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel