Re: [Xen-devel] [PATCH v3 2/3] xen, cpu_hotplug: call device_offline instead of cpu_down

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 10/19/2015 12:55 PM, Stefano Stabellini wrote:
> When offlining a cpu, instead of cpu_down, call device_offline, which
> also takes care of updating the cpu.dev.offline field. This keeps the
> sysfs file /sys/devices/system/cpu/cpuN/online, up to date.  Also move
> the call to disable_hotplug_cpu, because it makes more sense to have it
> there.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: konrad.wilk@xxxxxxxxxx
> CC: boris.ostrovsky@xxxxxxxxxx
> CC: david.vrabel@xxxxxxxxxx
> ---
>   drivers/xen/cpu_hotplug.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
> index 43de1f5..78804b5 100644
> --- a/drivers/xen/cpu_hotplug.c
> +++ b/drivers/xen/cpu_hotplug.c
> @@ -18,6 +18,8 @@ static void enable_hotplug_cpu(int cpu)
>   
>   static void disable_hotplug_cpu(int cpu)
>   {
> +       if (cpu_online(cpu))
> +               device_offline(get_cpu_device(cpu));
>         if (cpu_present(cpu))
>                 xen_arch_unregister_cpu(cpu);
Do we want to call device_online() when plugging cpu in?

And take sysfs lock?


-boris


>   
> @@ -55,7 +57,6 @@ static void vcpu_hotplug(unsigned int cpu)
>                 enable_hotplug_cpu(cpu);
>                 break;
>         case 0:
> -               (void)cpu_down(cpu);
>                 disable_hotplug_cpu(cpu);
>                 break;
>         default:

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel