Re: [Xen-devel] [PATCH] tools/xenpaging: install directory with default permission

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-10-21 at 13:10 +0100, Wei Liu wrote:
> There is no need to explicitly ask for 700.

Is the rationale for 0700 explicitly not that the files in here will
contain possibly sensitive date from guest memory?

i.e. the use of something other than the default is deliberate.

If you think that is wrong then I think the changelog should explain why.


> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  tools/xenpaging/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
> index 2407a30..4badaae 100644
> --- a/tools/xenpaging/Makefile
> +++ b/tools/xenpaging/Makefile
> @@ -24,7 +24,7 @@ xenpaging: $(OBJS)
>       $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
>  
>  install: all
> -     $(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
> +     $(INSTALL_DIR) $(DESTDIR)$(XEN_PAGING_DIR)
>       $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
>       $(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel