[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [V7 3/4] x86/xsaves: enable xsaves/xrstors for hvm guest



>>> On 20.10.15 at 10:21, <shuai.ruan@xxxxxxxxxxxxxxx> wrote:
> @@ -4784,6 +4804,13 @@ int hvm_msr_write_intercept(unsigned int msr, uint64_t 
> msr_content,
>             return X86EMUL_EXCEPTION;
>          break;
>  
> +    case MSR_IA32_XSS:
> +        /* No XSS features currently supported for guests. */
> +        if ( !cpu_has_xsaves || msr_content != 0 )
> +            goto gp_fault;
> +        v->arch.hvm_vcpu.msr_xss = msr_content;
> +        break;

Considering you add this write (and the msr_xss field in the first place)
despite it always being zero, I'd really like you to also add code
supporting save/restore of this new MSR. Or did I overlook something?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.