Re: [Xen-devel] [PATCH v2 5/6] xen: sched: get rid of the per domain vCPU list in RTDS

[Meng Xu <xumengpanda@xxxxxxxxx>]

2015-10-14 11:54 GMT-04:00 Dario Faggioli <dario.faggioli@xxxxxxxxxx>:
> As, curently, there is no reason for bothering having
> it and keeping it updated.
>
> In fact, it is only used for dumping and changing
> vCPUs parameters, but that can be achieved easily with
> for_each_vcpu.
>
> While there, take care of the case when
> XEN_DOMCTL_SCHEDOP_getinfo is called but no vCPUs have
> been allocated yet (by returning the default scheduling
> parameters).
>
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> ---
> Cc: Meng Xu <mengxu@xxxxxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Changes from v1:
>  * address the case when d->vcpu[] has not been allocated
>    yet, as requested during review;
>  * style: space before brackets of for_each_vcpu, as
>    requested during review;
>  * used 'v' instead of 'vc' for 'vcpu' (in new code).
> ---
> Not applying the review tags, as the patch changed a little
> bit.
> ---
>  xen/common/sched_rt.c |   54 
> ++++++++++++++++++++++++-------------------------
>  1 file changed, 26 insertions(+), 28 deletions(-)
>

Reviewed-by: Meng Xu <mengxu@xxxxxxxxxxxxx>

Best,

Meng


-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania
http://www.cis.upenn.edu/~mengxu/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel