Re: [Xen-devel] [PATCH] xl: log an error if libxl_cpupool_destroy() fails

[Juergen Gross <jgross@xxxxxxxx>]

On 10/22/2015 07:14 PM, Dario Faggioli wrote:
> In fact, right now, failing at destroying a cpupool is just
> not reported to the user in any explicit way. Log an error,
> as it is customary for xl in these cases.
>
> While there, take the chance to turn a couple of xl exit
> codes into EXIT_[SUCCESS|FAILURE], as discussed and agreed
> here:
>
>   http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01336.html
>   http://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01341.html
>
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Juergen Gross <jgross@xxxxxxxx>
> ---
>   tools/libxl/xl_cmdimpl.c |   10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 365798b..5a5f959 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -7581,13 +7581,15 @@ int main_cpupooldestroy(int argc, char **argv)
>       if (libxl_cpupool_qualifier_to_cpupoolid(ctx, pool, &poolid, NULL) ||
>           !libxl_cpupoolid_is_valid(ctx, poolid)) {
>           fprintf(stderr, "unknown cpupool '%s'\n", pool);
> -        return 1;
> +        return EXIT_FAILURE;
>       }
>
> -    if (libxl_cpupool_destroy(ctx, poolid))
> -        return 1;
> +    if (libxl_cpupool_destroy(ctx, poolid)) {
> +        fprintf(stderr, "Can't destroy cpupool '%s'\n", pool);
> +        return EXIT_FAILURE;
> +    }
>
> -    return 0;
> +    return EXIT_SUCCESS;
>   }
>
>   int main_cpupoolrename(int argc, char **argv)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel