Re: [Xen-devel] [PATCH v5 7/9] x86/intel_pstate: add a booting param to select the driver to load

["Wang, Wei W" <wei.w.wang@xxxxxxxxx>]

On 07/10/2015 23:46,  Jan Beulich wrote:
> >>> On 14.09.15 at 04:32, <wei.w.wang@xxxxxxxxx> wrote:
> > --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c
> > +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c
> > @@ -647,9 +648,11 @@ static int __init cpufreq_driver_init(void)
> >      int ret = 0;
> >
> >      if ((cpufreq_controller == FREQCTL_xen) &&
> > -        (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL))
> > -        ret = cpufreq_register_driver(&acpi_cpufreq_driver);
> > -    else if ((cpufreq_controller == FREQCTL_xen) &&
> > +        (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)) {
> > +            ret = intel_pstate_init();
> > +            if (ret)
> > +                ret = cpufreq_register_driver(&acpi_cpufreq_driver);
> > +    } else if ((cpufreq_controller == FREQCTL_xen) &&
> >          (boot_cpu_data.x86_vendor == X86_VENDOR_AMD))
> >          ret = powernow_register_driver();
> 
> Since you're basically modifying the entire body of the function, please gets 
> its
> coding style corrected as you fiddle with it.

Ok, I guess you was probably referring to the remaining lines in the function - 
"(boot_cpu_data.x86_vendor == X86_VENDOR_AMD))".. Will align them as well.

Best,
Wei

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel