Re: [Xen-devel] [PATCH] Handles the error returned by the xc_dom_allocate function

[Wei Liu <wei.liu2@xxxxxxxxxx>]

Aside from what Dario said.

On Sun, Oct 25, 2015 at 03:32:24PM +0530, Lasya Venneti wrote:
> ---
>  tools/xenstore/init-xenstore-domain.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/xenstore/init-xenstore-domain.c 
> b/tools/xenstore/init-xenstore-domain.c
> index 0d12169..d17aab5 100644
> --- a/tools/xenstore/init-xenstore-domain.c
> +++ b/tools/xenstore/init-xenstore-domain.c
> @@ -42,6 +42,8 @@ static int build(xc_interface *xch, int argc, char** argv)
>       snprintf(cmdline, 512, "--event %d --internal-db", rv);
>  
>       dom = xc_dom_allocate(xch, cmdline, NULL);
> +     if(dom==NULL)

Coding style is wrong. It should be

        if (dom == NULL)

Note the whitespaces.


> +             return -1;

And, please set rv to a proper error code (presumably ENOMEM) and use
goto err, otherwise you're leaking xs_fd.

BTW I notice that xs_fd is leaked in success path. You can submit
another path for it if you feel keen enough.

Wei.

>       rv = xc_dom_kernel_file(dom, argv[1]);
>       if (rv) goto err;
>  
> -- 
> 1.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel