Re: [Xen-devel] [PATCH MINI-OS v2] xenbus: notify the other end when necessary

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Wei Liu, le Mon 26 Oct 2015 12:47:56 +0000, a écrit :
> -            if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < 
> sizeof(msg))
> +            if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons < 
> sizeof(msg)) {
> +                notify_remote_via_evtchn(start_info.store_evtchn);
>                  break;
> +            }

>              if (xenstore_buf->rsp_prod - xenstore_buf->rsp_cons <
> -                    sizeof(msg) + msg.len)
> +                    sizeof(msg) + msg.len) {
> +                notify_remote_via_evtchn(start_info.store_evtchn);

Actually thinking...  In principle we should not need these two
notifications: we have already notified last time we consumed a message.
Notifying again shouldn't be bringing anything new.  Do you actually see
a difference with these?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel