Re: [Xen-devel] [V8 3/4] x86/xsaves: enable xsaves/xrstors for hvm guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.10.15 at 11:48, <shuai.ruan@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/xstate.c
> +++ b/xen/arch/x86/xstate.c
> @@ -23,8 +23,8 @@ static u32 __read_mostly xsave_cntxt_size;
>  
>  /* A 64-bit bitmask of the XSAVE/XRSTOR features supported by processor. */
>  u64 __read_mostly xfeature_mask;
> -static unsigned int * __read_mostly xstate_offsets;
> -static unsigned int * __read_mostly xstate_sizes;
> +unsigned int * __read_mostly xstate_offsets;
> +unsigned int * __read_mostly xstate_sizes;

I said before that without xstate_offsets being used anywhere outside
this file it shouldn't be made non-static.

Also please note that the saving/restoring of XSS really belongs
here instead of in patch 2.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel