[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 1/5] xl: convert main() exit codes to EXIT_[SUCCESS|FAILURE]



On Tue, Oct 27, 2015 at 03:20:48PM +0530, Harmandeep Kaur wrote:
[...]
>  };
>  
> +/*
> + *The xl process should always return either EXIT_SUCCESS or
> + *EXIT_FAILURE. main_* functions, implementing the various xl
> + *commands, can be treated as main() as if they are returning
> + *a process exit status and not a function return value.
> + */
> +

Missing spaces after "*". E.g.
   /*
    * The xl process ....
    * EXIT_FAILURE
    * ...
    */

With that fixed:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

(This means after fixing the minor problem you can put the above tag in
your commit message. If in doubt, please ask.)


>  int main_vcpulist(int argc, char **argv);
>  int main_info(int argc, char **argv);
>  int main_sharing(int argc, char **argv);
> -- 
> 1.9.1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.