Re: [Xen-devel] [PATCH] xen/mm: Improve message in populate physmap when the domain is direct mapped

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/10/15 11:49, Julien Grall wrote:
> Hi Andrew,
>
> On 27/10/15 11:45, Andrew Cooper wrote:
>> On 27/10/15 11:33, Julien Grall wrote:
>>> The current domain and the domain pointed by the variable "d" are not
>>> the same.
>>>
>>> However, when it's not possible to get a reference on the page, the
>>> target domain ID is not printed. This makes the message difficult to
>>> understand.
>>>
>>> Improve the message by printing the target domain ID.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, with a
>> suggestion as well.
>>
>>> ---
>>> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>> Cc: Jan Beulich <jbeulich@xxxxxxxx>
>>> Cc: Keir Fraser <keir@xxxxxxx>
>>> Cc: Tim Deegan <tim@xxxxxxx>
>>> ---
>>>  xen/common/memory.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/xen/common/memory.c b/xen/common/memory.c
>>> index f6aed0d..206955f 100644
>>> --- a/xen/common/memory.c
>>> +++ b/xen/common/memory.c
>>> @@ -141,7 +141,7 @@ static void populate_physmap(struct memop_args *a)
>>>                      {
>>>                          gdprintk(XENLOG_INFO,
>>>                                   "mfn %#"PRI_xen_pfn" doesn't belong to 
>>> the"
>>> -                                 " domain\n", mfn);
>>> +                                 " domain %d\n", mfn, d->domain_id);
>> This could easily be shortened to "doesn't belong to d%d" which matches
>> our other domain identification.
> I also just noticed that the message is split between 2 lines. IIRC, we
> are trying to avoid that to allow grep working.
>
> I will resend this patch with:
>
> gprintk(XENLOG_INFO,
>       "mfn %#"PRI_xen_pfn" doesn't belong to d%d\n",
>       mfn, d->domain_id).
>
> Can I keep your reviewed-by with that change?

Certainly.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel