[Xen-devel] [PATCH 0/6] Remove some usage of shadow variable

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi all,

I wrote this patch series after noticing that one of my series [1] was
shadowing a variable and GCC didn't warn it.

So I've turned on -Wshadow and look at if there is other places abusing
of shadow variable in Xen.

This series is not complete and only contain the more simple changes.

I'd like to have some input to know whether turning on -Wshadow would be
sensible in the future.

Regards,

[1] http://lists.xen.org/archives/html/xen-devel/2015-10/msg01354.html

Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Keir Fraser <keir@xxxxxxx>
Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Cc: Tim Deegan <tim@xxxxxxx>

Julien Grall (6):
  xen/arm: domain_build: Avoid to shadow the variable "mod" in
    write_properties
  xen/common: domain: Avoid to shadow the variable "d" in do_vcpu_op
  xen/common: grant_table: Avoid to shadow "frame" in
    __gnttab_map_grant_ref
  xen/common: memory: Avoid to shadow the variable "d" in do_memory_op
  xen/common: sched: Avoid to shadow the variable "cur" in runq_tickle
  xen/common: sched-rt: Avoid to shadow the variable "svc" in
    rt_dom_cntl

 xen/arch/arm/domain_build.c | 10 +++++-----
 xen/common/domain.c         |  1 -
 xen/common/grant_table.c    |  1 -
 xen/common/memory.c         |  3 ---
 xen/common/sched_credit2.c  |  2 --
 xen/common/sched_rt.c       |  2 +-
 6 files changed, 6 insertions(+), 13 deletions(-)

-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel