Re: [Xen-devel] [PATCH 12/13] vmx: Add a call-back to apply TSC scaling ratio to hardware

[Haozhong Zhang <haozhong.zhang@xxxxxxxxx>]

On Tue, Oct 27, 2015 at 07:33:46AM -0600, Jan Beulich wrote:
> >>> On 28.09.15 at 09:13, <haozhong.zhang@xxxxxxxxx> wrote:
> > This patch adds a new call-back setup_tsc_scaling in struct
> > hvm_function_table to apply the TSC scaling ratio to hardware. For VMX,
> > it writes the TSC scaling ratio to VMCS field TSC_MULTIPLIER.
> > 
> > Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
> 
> Looking at this (last non-tools one) patch, I wonder how if this is
> needed things can be correct at the point of the series prior to
> this patch. IOW - is the series correctly ordered?
> 
> Jan
> 

If I keep the scaling logic out of vmx_set_tsc_offset(), then patch 11
will be not necessary. Then, I can move patch 12 before patch 10. The
reordered patch 12 only adds a callback which is never called until
patch 10 is applied.

Haozhong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel