Re: [Xen-devel] [PATCH v3 1/9] libxc: reorganize domain builder guest memory allocator

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Oct 28, 2015 at 04:51:05PM +0100, Juergen Gross wrote:
[...]
> >>+static int xc_dom_alloc_pad(struct xc_dom_image *dom, xen_vaddr_t end)
> >>+{
> >>+    unsigned int page_size = XC_DOM_PAGE_SIZE(dom);
> >>+    xen_pfn_t pages;
> >>+
> >>+    if ( end & (page_size - 1) )
> >>      {
> >>          xc_dom_panic(dom->xch, XC_INTERNAL_ERROR,
> >>                       "%s: segment start isn't page aligned (0x%" PRIx64 
> >> ")",
> >
> >"segment end"?
> 
> No. This function is called to add a padding allocation before the start
> of a new segment, which has to start at page boundary. Maybe a comment
> should clarify this. :-)
> 

Heh, I worked out this function was used to add padding segment but
was confused by the dissonance.

A simpler solution might be just change "end" to "start"? I think it is
sensible because it is the start of the padding.

In any case, it's up to you. :-)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel