Re: [Xen-devel] OSSTest nested patch PART2 -- L1 host has no 'Suite' property

["Hu, Robert" <robert.hu@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]
> Sent: Wednesday, October 28, 2015 7:58 PM
> To: Hu, Robert <robert.hu@xxxxxxxxx>
> Cc: 'Ian Campbell' <ian.campbell@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxx
> Subject: Re: OSSTest nested patch PART2 -- L1 host has no 'Suite' property
> 
> Hu, Robert writes ("OSSTest nested patch PART2 -- L1 host has no 'Suite'
> property"):
> > Now the patch has been refined to get whole
> 'test-amd64-amd64-qemuu-nested' pass.
> 
> How exciting :-).
> 
> > But still one trivial issue I observed in the test log: L1 host has no 
> > 'Suite'
> property.
> > Any suggestions to improve this?
> 
> Two questions:
> 
> 1. I think this (missing suite) probably ought to be fatal.  Which is
> the first ts-* script which complains about it ?
[Hu, Robert] 

ts-xen-install l1

> 
> 2. In general the suite runvars are set by make-flight.  So I think
> your patch to make-flight needs adjusting.  TBH I think the suite
> should be set in do_hvm_debian_test_one for all Debian HVM tests,
> even though maybe nothing uses it now.
[Hu, Robert] 

In selecthost(),

if (defined $job) {
        $ho->{Suite} = get_runvar_default("${ident}_suite",$job,
                                          $c{DebianSuite});
    }

by default shall be the config file containing value, which I absolutely have
set.
The odd thing shall be $job is not defined. Any case possible?
Maybe this only happens in my debugging steps, in whole job running, it
probably would disappear.

> 
> Thanks,
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel