Re: [Xen-devel] [PATCH] libxlu: avoid linker warnings

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Oct 29, 2015 at 04:05:26AM -0600, Jan Beulich wrote:
> Recent ld warns about libxenlight.so's dependency libraries not being
> available, which can be easily avoided by not just passing the raw
> library name on ld's command line.
> 
> In the course of checking how things fit together (I originally
> suspected the warning to come from the linking of xl) I also noticed a
> stray L in SHLIB_libxenguest, which gets removed at once.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -40,7 +40,7 @@ SHLIB_libxenctrl  = -Wl,-rpath-link=$(XE
>  
>  CFLAGS_libxenguest = -I$(XEN_LIBXC)/include $(CFLAGS_xeninclude)
>  LDLIBS_libxenguest = $(XEN_LIBXC)/libxenguest$(libextension)
> -SHLIB_libxenguest  = -Wl,-rpath-link=L$(XEN_LIBXC)
> +SHLIB_libxenguest  = -Wl,-rpath-link=$(XEN_LIBXC)

Heh, I wonder how this ever worked, but it turns out SHLIB_libxenguest
is not used in tree.

>  
>  CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
>  LDLIBS_libxenstore = $(XEN_XENSTORE)/libxenstore$(libextension)
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -41,7 +41,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS)
>  LIBXL_LIBS += $(PTHREAD_LIBS)
>  LIBXL_LIBS += $(LIBXL_LIBS-y)
>  
> -LIBXLU_LIBS = libxenlight.so
> +LIBXLU_LIBS = $(LDLIBS_libxenlight)
>  

This looks correct to me.

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel